[webkit-reviews] review granted: [Bug 27961] bugzilla-tool land-patches needs --queue mode : [Attachment 34019] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 3 16:52:07 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27961: bugzilla-tool land-patches needs --queue mode
https://bugs.webkit.org/show_bug.cgi?id=27961
Attachment 34019: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34019&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
get_path_from_webkit_script
should be webkit_script_path I think. we don't tend to prefix getters with
"get"
Isn't there a ! operator in python?
not options.commit_queue
318 cls.run_webkit_tests(launch_safari=not
options.commit_queue)
reads a little odd with "not" to my eyes.
Otherwise looks good!
More information about the webkit-reviews
mailing list