[webkit-reviews] review denied: [Bug 27734] WINCE PORT: font related changes : [Attachment 34012] updated patch with clearer comments, updated handling of negative spacing, and a few style fixes

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Joe Mason <joe.mason at torchmobile.com>'s request for
review:
Bug 27734: WINCE PORT: font related changes
https://bugs.webkit.org/show_bug.cgi?id=27734

Attachment 34012: updated patch with clearer comments, updated handling of
negative spacing, and a few style fixes
https://bugs.webkit.org/attachment.cgi?id=34012&action=review

------- Additional Comments from mitz at webkit.org
> +#if PLATFORM(WINCE)
> +    // Some sites set the spacing to -1 to make text more compact.  But
WinMobile already
> +    // compacts the text to save on screen space, so this makes it overlap. 
If the spacing is
> +    // negative, widen is slightly to counteract this.
> +    void setLetterSpacing(short s) { m_letterSpacing = s < 0 ? s + 1 : s; }
> +#else

I don’t think this is the right place to make this platform-specific
adjustment. It will also affect computed style.