[webkit-reviews] review denied: [Bug 27425] adding GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33977] blatant cut/paste copy of make_names.pl

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 33977: blatant cut/paste copy of make_names.pl
https://bugs.webkit.org/attachment.cgi?id=33977&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's unclear to me why we can't just modify the existing make_names.pl instead
of copying it?	The whole point of my previous r- was that you were proposing
checking in copy/paste code.  Now you're doing so again except in perl form. :)
 Yes, make_names.pl is ugly.  You should feel free to re-write it in python if
you like, but I think that would be a bit large of an undertaking.

If it would be a huge diff to make_names.pl to teach it about gdom then maybe
we should just check in a separate script.  But I still think that's a mistake.


Checking in a hack like this is analogous to taking out a loan of money from a
bank.  The loan will require continuous interest payments (keeping track of
changes across the forked files) as well as eventually someone will have to
re-pay the principle by un-forking the files!  You might not be the one who
ends up paying that cost... so we as a project don't want to let you take out
such a loan. :)