[webkit-reviews] review denied: [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. : [Attachment 33982] Fixed a code style guideline issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 09:45:34 PDT 2009


Eric Seidel <eric at webkit.org> has denied Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 27942: Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.
https://bugs.webkit.org/show_bug.cgi?id=27942

Attachment 33982: Fixed a code style guideline issue
https://bugs.webkit.org/attachment.cgi?id=33982&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please see http://webkit.org/coding/contributing.html.

You need to add your test and expected results as part of this patch.  If this
change is untestable, you need to explain why.

See http://webkit.org/coding/coding-style.html which documents how we use full
english word/phrases for variable names.  Thus:
+    OptionElement* selectedEl = 0;
is not an OK variable name.

The indent is also wrong here:
+	       selectedEl->setSelectedState(false);


More information about the webkit-reviews mailing list