[webkit-reviews] review requested: [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings : [Attachment 33972] corrections noted from other reviews (e.g. removal of args on prototypes)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 3 06:40:22 PDT 2009
Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked for review:
Bug 27426: adding GDOMBinding.cpp/h as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27426
Attachment 33972: corrections noted from other reviews (e.g. removal of args on
prototypes)
https://bugs.webkit.org/attachment.cgi?id=33972&action=review
------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
please note: the ordering of the #includes is noted as being out-of-order
[strictly speaking] but there is a comment advising that they are not
out-of-order, they're grouped together by purpose. the reason is because this
file is equivalent to and was constructed out of many JS*Binding*.cpp files.
if ever this one file GDOMBindings.cpp is split down into many files, it will
be extra work for developers to re-construct the header dependencies of the
groupings.
More information about the webkit-reviews
mailing list