[webkit-reviews] review denied: [Bug 27931] [commit+] JSNodeCustom should call document() instead of scriptExecutionContext() : [Attachment 33947] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 2 02:50:45 PDT 2009
Darin Adler <darin at apple.com> has denied review:
Bug 27931: [commit+] JSNodeCustom should call document() instead of
scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=27931
Attachment 33947: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33947&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
On reflection, I don't think this patch is right.
Document is derived from ScriptExecutionContext, so there's no need to overload
toJSDOMGlobalObject to take a Document*. The JSNodeCustom.cpp change can stand
alone. No need to change JSDOMGLobalObject.h and .cpp.
I'm changing my review to review-.
More information about the webkit-reviews
mailing list