[webkit-reviews] review requested: [Bug 27928] Inspector: Make Bottom "Drawer" More Extensible To Support Other Views : [Attachment 33945] Drawer Support For Multiple Views

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27928: Inspector: Make Bottom "Drawer" More Extensible To Support Other
Views
https://bugs.webkit.org/show_bug.cgi?id=27928

Attachment 33945: Drawer Support For Multiple Views
https://bugs.webkit.org/attachment.cgi?id=33945&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
The ChangeLog covers some of the details.  But I'll still throw some notes
here.

BEFORE COMMIT:

- Console.js should be renamed to ConsoleView.js in order to preserve the
history (good point from Tim).

NOTES:

- Drawer.js handles the Sliding View opening/closing.  It may contain multiple
views with their own status bar icons.
- ConsoleView.js one such view.  (Basically the old Console.js)
- ChangesView.js a new view that may be similar to "FireDiff" for Firebug, to
show Changes made via the inspector.
- The ChangesView is off in the patch, there are a number of "TODO" items that
explicitly mention what needs to be done to enable it.
- Images for the ChangesView are not yet implemented.  There are a number of
"TODO" items that explicitly mention which images are needed.