[webkit-reviews] review granted: [Bug 25491] WebFrame leak when a subframe removes itself : [Attachment 29918] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 30 15:59:19 PDT 2009

Brady Eidson <beidson at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 25491: WebFrame leak when a subframe removes itself

Attachment 29918: patch

------- Additional Comments from Brady Eidson <beidson at apple.com>
As with all FrameLoader voodoo, I'm not 100% sure on this one - but it seems
quite safe and reasonable, and fixes the bug.

I think it's a shame the FrameLoadDelegate dumping that DRT does doesn't make
an effort to dump the error for didFailLoadWithError, but that enhancement is
outside the scope of this patch.


More information about the webkit-reviews mailing list