[webkit-reviews] review requested: [Bug 25474] fix skipped windows tests from r43007 : [Attachment 29922] 2009-04-29 Ojan Vafai <ojan at chromium.org>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 30 14:24:28 PDT 2009

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 25474: fix skipped windows tests from r43007

Attachment 29922: 2009-04-29  Ojan Vafai  <ojan at chromium.org>

------- Additional Comments from Ojan Vafai <ojan at chromium.org>

	Reviewed by NOBODY (OOPS!).

	Fix tests that depend on Mac-specific metrics now that text controls
	are sized according to font metrics (r43007).

	Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

	* fast/forms/textarea-appearance-wrap-expected.txt:
	* fast/forms/textarea-appearance-wrap.html:
	* fast/forms/textarea-hard-linewrap.html:
	These three tests only really care that a line-wrap character is
	with forms that have the appropriate wrap value and not with other
	So checking that the submit contents have a line-wrap character,
instead of
	looking for it in a specific place, is sufficient. This gets around
that we
	wrap in a different place in some cases on Mac and Windows.

	* fast/replaced/table-percent-height-expected.txt:
	* fast/replaced/table-percent-height-text-controls-expected.txt: Added.
	* fast/replaced/table-percent-height-text-controls.html: Added.
	* fast/replaced/table-percent-height.html:
	Pulled out the cases in table-percent-height.html that had text
controls and moved
	them into their own test. The new test doesn't assert specific metrics,
it just
	spits them out. This allows us to have different expected results for
Windows and
	Mac without having "FAIL" messages in the expected results. It's not
perfect, but
	it seems better than any alternatives I could come up with.

	* platform/win/Skipped:
 11 files changed, 325 insertions(+), 150 deletions(-)

More information about the webkit-reviews mailing list