[webkit-reviews] review granted: [Bug 25440] setTimeout should stringify non-string/non-function first arguments : [Attachment 29903] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 29 23:32:12 PDT 2009
Oliver Hunt <oliver at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 25440: setTimeout should stringify non-string/non-function first arguments
https://bugs.webkit.org/show_bug.cgi?id=25440
Attachment 29903: patch
https://bugs.webkit.org/attachment.cgi?id=29903&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
you should stop running if toString results in an exception (esp. for
setInterval, we don't want a timer for a code that does nothing); Also add
tests to cover setInterval
More information about the webkit-reviews
mailing list