[webkit-reviews] review denied: [Bug 25275] use AtomicString to speed up window and document interceptors : [Attachment 29590] patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 25275: use AtomicString to speed up window and document interceptors
https://bugs.webkit.org/show_bug.cgi?id=25275

Attachment 29590: patch v1
https://bugs.webkit.org/attachment.cgi?id=29590&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKit uses DEFINE_STATIC_LOCAL for local statics.  The Mac build will have
trouble if we don't here too.

// Use these to declare and define a static local variable (static T;) so that
//  it is leaked so that its destructors are not called at exit. Using this
//  macro also allows workarounds a compiler bug present in Apple's version of
GCC 4.0.1.
#if COMPILER(GCC) && defined(__APPLE_CC__) && __GNUC__ == 4 && __GNUC_MINOR__
== 0 && __GNUC_PATCHLEVEL__ == 1
#define DEFINE_STATIC_LOCAL(type, name, arguments) \
    static type* name##Ptr = new type arguments; \
    type& name = *name##Ptr
#else
#define DEFINE_STATIC_LOCAL(type, name, arguments) \
    static type& name = *new type arguments
#endif