[webkit-reviews] review denied: [Bug 23526] clipToImageBuffer() for all platforms : [Attachment 27361] clipToImageBuffer for cairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 29 14:09:50 PDT 2009

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 23526: clipToImageBuffer() for all platforms

Attachment 27361: clipToImageBuffer for cairo

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think we can make this more clear.

The problem here is that in CG you can set a mask image on the context, and
then CG will automatically apply it when necessary.

In Cairo, masking is an immediate operation.

GraphicsContext expects masking to function lazily like CG does.

So we have to fix GraphicsContextCairo to save off the mask image, and apply
the mask at the last moment possible (when popping the context).

I think we could do this clearer by saving the mask image on the
GraphicsContextState and applying it during m_data->restore();

You could write a new applyMaskImage() function on m_data which does the actual
apply using the stored image.	the mask image would not inherit between
graphics context states.

Does that seem sane?

More information about the webkit-reviews mailing list