[webkit-reviews] review denied: [Bug 25056] Make editing stop using Position::m_offset directly : [Attachment 29273] Make Position::m_offset private and fix callers to use either deprecatedEditingOffset() or offsetInContainer()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25056: Make editing stop using Position::m_offset directly
https://bugs.webkit.org/show_bug.cgi?id=25056

Attachment 29273: Make Position::m_offset private and fix callers to use either
deprecatedEditingOffset() or offsetInContainer()
https://bugs.webkit.org/attachment.cgi?id=29273&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think the key here is to first create a patch that is guaranteed to not
change behavior (using functions by new names, using functions instead of
direct access to data members). And then have a much smaller patch for all the
behavior changes.

Review should be straightforward for a patch that changes no behavior. And then
we can carefully review the behavior changes without the distraction of the
editorial-only changes.