[webkit-reviews] review denied: [Bug 25448] Reveal execution line after SourceFrame loading : [Attachment 29852] Reveal current execution line(if any) when script source is loaded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 10:43:49 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied 's request for review:
Bug 25448: Reveal execution line after SourceFrame loading
https://bugs.webkit.org/show_bug.cgi?id=25448

Attachment 29852: Reveal current execution line(if any) when script source is
loaded
https://bugs.webkit.org/attachment.cgi?id=29852&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   if (this._executionLine)
> +	     this.revealLine(this._executionLine);

The change is correct. But please use 4 spaces instead of two for indentation.

Also include a ChangeLog entry (use the prepare-ChangeLog script).


More information about the webkit-reviews mailing list