[webkit-reviews] review granted: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 29536] covermoreroles.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 21546: [GTK] ATK accessibility enhancements
https://bugs.webkit.org/show_bug.cgi?id=21546

Attachment 29536: covermoreroles.patch
https://bugs.webkit.org/attachment.cgi?id=29536&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    case ColumnRole:
> +	   //return ATK_ROLE_TABLE_COLUMN_HEADER; //?
> +	   return ATK_ROLE_UNKNOWN; // Matches Mozilla
[...]
> +    case BusyIndicatorRole:
> +	   return ATK_ROLE_PROGRESS_BAR; //?
> +    case ProgressIndicatorRole:
> +	   //return ATK_ROLE_SPIN_BUTTON; //Some confusion here in
AccessibilityRenderObject.cpp
[...]
> +    //case LabelRole: // TODO: add LabelRole?
> +    //    return ATK_ROLE_LABEL;

The only problem I have with this patch is the comments are confusing. That
TODO is about adding LabelRole to ATK, or to WebCore? If you can improve the
comments, and add a small explanation to the // ? ones, that would be great.