[webkit-reviews] review granted: [Bug 25424] media/video-played.html test doesn't take in account synchronization with media playback : [Attachment 29819] patch v1.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 27 09:32:05 PDT 2009
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 25424: media/video-played.html test doesn't take in account synchronization
with media playback
https://bugs.webkit.org/show_bug.cgi?id=25424
Attachment 29819: patch v1.
https://bugs.webkit.org/attachment.cgi?id=29819&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> + Note, this does not ensure a strict synchronization between the time
> + asked and the media playback. But given that media playback is the
> + slow part we just need to compensate the delay involved by playback.
compensate _for_ the delay.
> + if (playedTime < 0) {
> + // Deal with loop. Workd only once, hence the
warning
Typo here.
More information about the webkit-reviews
mailing list