[webkit-reviews] review granted: [Bug 25412] The Window object should be an EventTarget : [Attachment 29808] patch with tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 26 16:57:54 PDT 2009


mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 25412: The Window object should be an EventTarget
https://bugs.webkit.org/show_bug.cgi?id=25412

Attachment 29808: patch with tests
https://bugs.webkit.org/attachment.cgi?id=29808&action=review

------- Additional Comments from mitz at webkit.org
> Index: WebCore/page/DOMWindow.h
> ===================================================================
> --- WebCore/page/DOMWindow.h	(revision 42880)
> +++ WebCore/page/DOMWindow.h	(working copy)
> @@ -30,6 +30,7 @@
>  #include "PlatformString.h"
>  #include "RegisteredEventListener.h"
>  #include "SecurityOrigin.h"
> +#include "EventTarget.h"
>  #include <wtf/Forward.h>
>  #include <wtf/RefCounted.h>
>  #include <wtf/RefPtr.h>

Please keep in ASCII order.

r=me


More information about the webkit-reviews mailing list