[webkit-reviews] review granted: [Bug 16135] [GTK] Support caret browsing : [Attachment 29737] editorclientkeysv2.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 19:06:09 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 16135: [GTK] Support caret browsing

Attachment 29737: editorclientkeysv2.patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
(In reply to comment #18)
> The GtkBinding thing would be nice, but I don't see an issue way of doing it
> here, since for the bindings to work you need to go the parent class of the
> view in keypress, which happens quite a bit later than this.
> Also, the code for up/down/etc in caretBrowsing here is actually different
> the one in EventHandler, so I've left it here for now. We may unify it, but I

> think it should be done in a different patch.

Those sound sane to me. This one is go in my opinion, too. So r=me. Now let's
find someone to get the first one looked at.

More information about the webkit-reviews mailing list