[webkit-reviews] review granted: [Bug 25380] LayoutTests/media/video-played.html has a race condition when starting the test. : [Attachment 29768] patch v1.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 25380: LayoutTests/media/video-played.html has a race condition when
starting the test.
https://bugs.webkit.org/show_bug.cgi?id=25380

Attachment 29768: patch v1.
https://bugs.webkit.org/attachment.cgi?id=29768&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 42845)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2009-04-24  Pierre d'Herbemont  <pdherbemont at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fixed a race condition on the first 'played' attribute test start.
> +
> +	   Previously we were starting nearly right away to play, and probably
> +	   before receiving the 'canplay' event. Now we ensure we'll wait for
> +	   that 'canplay' event before attempting to play.

"...before starting the tests."

>		   waitForEvent("loadedmetadata");
> -		   waitForEvent("canplay", canplay);
> +		   waitForEvent("canplay", canplay); // Will triggers
nextTest() which launches the tests.

"Will trigger"

r=me