[webkit-reviews] review granted: [Bug 25370] Introduce ScriptEventListener to abstract away attribute event listener creation. : [Attachment 29749] Refactor away direct refs to JSLazyEventListener, v1.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 25370: Introduce ScriptEventListener to abstract away attribute event
listener creation.
https://bugs.webkit.org/show_bug.cgi?id=25370

Attachment 29749: Refactor away direct refs to JSLazyEventListener, v1.
https://bugs.webkit.org/attachment.cgi?id=29749&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine to me.

Why are you pulling:
Document* document = node->document();
 45 
into a local in all these functions. I don't ever see it used (except to take
up 3 lines of source) :)

I don't think these will compile for v8:
    PassRefPtr<JSLazyEventListener> createAttributeEventListener(Node*,
Attribute*);
 45	PassRefPtr<JSLazyEventListener> createAttributeEventListener(Frame*,
Attribute*);
Since you're returning V8LazyEventListener.

Looks fine to me though, assuming you fix the above (and that you've run the
tests).