[webkit-reviews] review denied: [Bug 25343] -webkit-box-shadow with 0, 0 offset ignores blur : [Attachment 29711] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Nate Chapin
<japhet at google.com>'s request for review:
Bug 25343: -webkit-box-shadow with 0,0 offset ignores blur
https://bugs.webkit.org/show_bug.cgi?id=25343

Attachment 29711: Patch
https://bugs.webkit.org/attachment.cgi?id=29711&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Good work and welcome :)

A couple of things about ChangeLog contents. It's actually very handy (like
when perusing trac), so we really try to put more details there. This would be
a good ChangeLog entry:

2009-04-22  Nate Chapin  <japhet at google.com>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=25343
	Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset ignores
blur.

	* WebCore\platform\graphics\skia\GraphicsContextSkia.cpp:
	(WebCore::GraphicsContext::setPlatformShadow): Added an extra check for
blur.

In other words:

 * URL of the bug
 * Brief description of the bug
 * For each change, brief documentation of what it is.

r-, but only because of this.

> +2009-04-22  Nate Chapin  <japhet at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
> +:
> +

> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 42752)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,10 @@
> +2009-04-22  Nate Chapin  <japhet at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
> +:
> +
>  2009-04-14  Xan Lopez  <xlopez at igalia.com>
>  
>	   Unreviewed version bump in preparation for 1.1.5 release.
> Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
> ===================================================================
> --- WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	(revision
42752)
> +++ WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	(working copy)
> @@ -963,7 +963,7 @@ void GraphicsContext::setPlatformShadow(
>	   return;
>  
>      // Detect when there's no effective shadow and clear the looper.
> -    if (size.width() == 0 && size.height() == 0) {
> +    if (size.width() == 0 && size.height() == 0 && blurInt == 0) {
>	   platformContext()->setDrawLooper(NULL);
>	   return;
>      }