[webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop support : [Attachment 29738] The clipboard, drag image and other implementations, improved

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 05:46:56 PDT 2009


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 29738: The clipboard, drag image and other implementations, improved
https://bugs.webkit.org/attachment.cgi?id=29738&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Removed braces from switch cases, C++ castings now in use, the dragged image is
now held where it was grabbed (used to be held at (0,0)).

Target element (on which the start of the drag was performed) can be NULL if it
has no renderer (but is that even possible, starting a drag on an element with
no renderer?), so we check for its existence and only then decide whether it's
a link or even image that we'll be dragging.


More information about the webkit-reviews mailing list