[webkit-reviews] review granted: [Bug 15616] [GTK] Add spell checking : [Attachment 29730] 0002-Add-spell-checking-languages-property.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted 's request for review:
Bug 15616: [GTK] Add spell checking
https://bugs.webkit.org/show_bug.cgi?id=15616

Attachment 29730: 0002-Add-spell-checking-languages-property.patch
https://bugs.webkit.org/attachment.cgi?id=29730&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   if (priv->spell_checking_languages)
> +	   {
> +	       char** langs = g_strsplit(priv->spell_checking_languages, ",",
-1);
> +	       for (int i = 0; langs[i]; i++)
> +	       {

Braces are still problematic here. I'll fix when landing, though.

> +GSList* webkit_web_settings_get_spell_languages(WebKitWebView *web_view)
> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(web_view), 0);
> +
> +    WebKitWebSettings* settings = webkit_web_view_get_settings(web_view);
> +    WebKitWebSettingsPrivate* priv = WEBKIT_WEB_SETTINGS_GET_PRIVATE
(settings);

You want to avoid using GET_PRIVATE macros wherever possible. They are a way
for people who need to keep binary compatibility and didn't add a priv pointer
to their object structures to fetch a private one, but is a considerable
performance hit when comparing with simply using the pointer. I'll change this
when landing, too.