[webkit-reviews] review requested: [Bug 16135] [GTK] Support caret browsing : [Attachment 29737] editorclientkeysv2.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 04:38:38 PDT 2009

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 16135: [GTK] Support caret browsing

Attachment 29737: editorclientkeysv2.patch

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, I've removed the systemKey commented code, and the handling of the
clipboard functions from here.

The GtkBinding thing would be nice, but I don't see an issue way of doing it
here, since for the bindings to work you need to go the parent class of the
view in keypress, which happens quite a bit later than this.

Also, the code for up/down/etc in caretBrowsing here is actually different than
the one in EventHandler, so I've left it here for now. We may unify it, but I
think it should be done in a different patch.

More information about the webkit-reviews mailing list