[webkit-reviews] review denied: [Bug 15616] [GTK] Add spell checking (and grammar?) : [Attachment 29700] 0001-Add-enable-spell-checking-property.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 18:42:53 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has denied 's request for review:
Bug 15616: [GTK] Add spell checking (and grammar?)

Attachment 29700: 0001-Add-enable-spell-checking-property.patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>  bool EditorClient::isContinuousSpellCheckingEnabled()
>  {
> -    notImplemented();
> -    return false;
> +    WebKitWebSettings* settings;
> +    gboolean enabled;
> +
> +    settings = webkit_web_view_get_settings(m_webView);
> +    g_object_get(settings, "enable-spell-checking", &enabled, NULL);

Move the initialization of settins to where it is declared; there is another
ocurrence of this a few lines down, fix it too =). Otherwise looks good. Please
fix this, and upload another patch adding a ChangeLog entry, too.

More information about the webkit-reviews mailing list