[webkit-reviews] review denied: [Bug 25335] crash in VisibleSelection::appendTrailingWhitespace() : [Attachment 29721] Check that it.atEnd() in addition to it.length() > 0

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Eric Roman <eroman at chromium.org>'s
request for review:
Bug 25335: crash in VisibleSelection::appendTrailingWhitespace()
https://bugs.webkit.org/show_bug.cgi?id=25335

Attachment 29721: Check that it.atEnd() in addition to it.length() > 0
https://bugs.webkit.org/attachment.cgi?id=29721&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is the wrong fix. The CharacterIterator::length is guaranteed to return 0
when it's at the end, and the fact that it's not is a bug.

The correct fix, as suggested earlier in this report, is to make sure the
TextIterator constructors initialize m_textLength to 0 in all code paths.