[webkit-reviews] review denied: [Bug 25335] crash in VisibleSelection::appendTrailingWhitespace() : [Attachment 29721] Check that it.atEnd() in addition to it.length() > 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 17:33:32 PDT 2009

Darin Adler <darin at apple.com> has denied Eric Roman <eroman at chromium.org>'s
request for review:
Bug 25335: crash in VisibleSelection::appendTrailingWhitespace()

Attachment 29721: Check that it.atEnd() in addition to it.length() > 0

------- Additional Comments from Darin Adler <darin at apple.com>
This is the wrong fix. The CharacterIterator::length is guaranteed to return 0
when it's at the end, and the fact that it's not is a bug.

The correct fix, as suggested earlier in this report, is to make sure the
TextIterator constructors initialize m_textLength to 0 in all code paths.

More information about the webkit-reviews mailing list