[webkit-reviews] review denied: [Bug 24900] Render empty optgroup elements. : [Attachment 29559] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 17:06:00 PDT 2009

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 24900: Render empty optgroup elements.

Attachment 29559: patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
+	 // Odd tags like <div> will already have been removed from the tree.
+	 current = current->traverseNextSibling(this);

This needs a "so what?" explanation. 

// We traverse nextSibling instead of nextNode because... why?

Otherwise this looks fine.  If you update that comment you're good to land IMO.

If you post an updated comment I'm happy to land this for you.

More information about the webkit-reviews mailing list