[webkit-reviews] review denied: [Bug 25345] Make EventListener::virtualisAttribute pure virtual : [Attachment 29712] Change EventListener::virtualisAttribute to be pure virtual, v1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 10:03:38 PDT 2009

Darin Adler <darin at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 25345: Make EventListener::virtualisAttribute pure virtual

Attachment 29712: Change EventListener::virtualisAttribute to be pure virtual,

------- Additional Comments from Darin Adler <darin at apple.com>
The overrides should be private, like the function in the base class.

Also, it's a programming mistake to call isAttribute on a subclass object, so
isAttribute should either be overridden to return false in those subclasses, or
be made private by putting "using EventListener::isAttribute" in the private
section of those classes.

Since this patch doesn't fix a bug, I'm going to say review- until you make the
overrides private.

More information about the webkit-reviews mailing list