[webkit-reviews] review requested: [Bug 24604] WebKit profiler reports incorrect total times : [Attachment 29707] Fixes heavy view.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 03:56:53 PDT 2009


Francisco Tolmasky <tolmasky at gmail.com> has asked  for review:
Bug 24604: WebKit profiler reports incorrect total times
https://bugs.webkit.org/show_bug.cgi?id=24604

Attachment 29707: Fixes heavy view.
https://bugs.webkit.org/attachment.cgi?id=29707&action=review

------- Additional Comments from Francisco Tolmasky <tolmasky at gmail.com>
Made it so that most the functions now match the behavior of Shark. Most
notably, in the heavy view, child nodes now represent the statistics of the
root node, but in the callstack originating at that node. Also added a number
of performance improvements, making it so the heavy tree is not calculated
until its nodes are revealed. Moved a lot out of C++ and into JS, allowing for
more representations and easier manipulations in the future.


More information about the webkit-reviews mailing list