[webkit-reviews] review granted: [Bug 17267] [GTK] Primary selection/clipboard support : [Attachment 24698] Copy link locations to the primary selection

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 17267: [GTK] Primary selection/clipboard support
https://bugs.webkit.org/show_bug.cgi?id=17267

Attachment 24698: Copy link locations to the primary selection
https://bugs.webkit.org/attachment.cgi?id=24698&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

This warning should be removed. There is no behavior change for webcore; we
could probably add GTK+ unit tests for this, though, in WebKit/gtk.

> +GtkClipboard* PasteboardHelperGtk::getPrimary(Frame* frame) const {
> +    WebKitWebView* webView = webkit_web_frame_get_web_view(kit(frame));
> +    return gtk_widget_get_clipboard(GTK_WIDGET (webView),
> +				       GDK_SELECTION_PRIMARY);
> +}
> +

I believe the only problem with this patch is the incorrect placement of braces
here. Whoever lands, please fix this, and rs=me on a second commit to fix the
other braces in this file.

I wonder if we should review the PasteBoard files placements as a whole,
sometime.