[webkit-reviews] review granted: [Bug 25329] v8 binding of ClientRectList doesn't have indexed access method : [Attachment 29695] Add V8ClientRectListCustom.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 16:42:45 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted 's request for
review:
Bug 25329: v8 binding of ClientRectList doesn't have indexed access method
https://bugs.webkit.org/show_bug.cgi?id=25329

Attachment 29695: Add V8ClientRectListCustom.cpp
https://bugs.webkit.org/attachment.cgi?id=29695&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks good, except for:

Add Bug URL (https://bugs.webkit.org/show_bug.cgi?id=25329) here..
> +	   Add indexed access method in v8 binding of ClientRectList.
> +
> +	   * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
> +	   (WebCore::INDEXED_PROPERTY_GETTER):


More information about the webkit-reviews mailing list