[webkit-reviews] review granted: [Bug 24977] InspectorController is difficult to get to on the Page : [Attachment 29150] Adds an inspectorController() const getter on Frame to clean up callsites

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 11:17:46 PDT 2009


Eric Seidel <eric at webkit.org> has granted James Robinson <jamesr at google.com>'s
request for review:
Bug 24977: InspectorController is difficult to get to on the Page
https://bugs.webkit.org/show_bug.cgi?id=24977

Attachment 29150: Adds an inspectorController() const getter on Frame to clean
up callsites
https://bugs.webkit.org/attachment.cgi?id=29150&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine.  I assume that Page::inspectorController() can never be null?

Also, you should consider adding a comment to Frame::inspectorController() in
the header, noting that it can return 0.

Otherwise looks good.  r+.  If you don't have commit bit, please upload a new
patch if you act on the above comments (or need to make other changes).


More information about the webkit-reviews mailing list