[webkit-reviews] review denied: [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend : [Attachment 28391] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 14:52:58 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16356: [GTK] Integrate GStreamer video with the graphics backend

Attachment 28391: Updated patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   Further implement MediaPlayerPrivate class on Gtk port.

I have read the patch, and tested/tried it. It seems to have a few regressions,
such as media/video-currentTime-set2.html now failing, and the poster at
http://webkit.org/blog/140/html5-media-support/ not showing 'Loading...'
anymore when I click play, nor displaying the video (I think this may be
actually a step forward, but I would like to have a smaller context to
investigate). I think you could split the patch in smaller ones, and we can
work through them one at a time. I suggest the following:

 - Reworking GST initialization
 - Additional error check
 - Supported formats
 - Play/pause fixes
 - Total/current bytes and time

I'll be glad to work with you on this, and review the patches.

More information about the webkit-reviews mailing list