[webkit-reviews] review denied: [Bug 25309] Use AtomicStrings more effectively in the V8 bindings : [Attachment 29648] Fix

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dave Moore
<davemoore at google.com>'s request for review:
Bug 25309: Use AtomicStrings more effectively in the V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=25309

Attachment 29648: Fix
https://bugs.webkit.org/attachment.cgi?id=29648&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> Index: bindings/v8/V8Binding.h
> ===================================================================
> --- bindings/v8/V8Binding.h	(revision 42710)
> +++ bindings/v8/V8Binding.h	(working copy)
> @@ -34,7 +34,7 @@
>  // FIXME: This is a temporary forwarding header until all bindings have
migrated
>  // over and v8_binding actually becomes V8Binding.
>  #include "v8_binding.h"
> -
> +#include "AtomicString.h"
>  namespace WebCore {
>  
>      // FIXME: Remove once migration is complete.
> @@ -51,7 +51,13 @@ namespace WebCore {
>      // FIXME: Remove once migration is complete.
>      inline String toWebCoreString(v8::Handle<v8::Value> obj)
>      {
> -	   return ToWebCoreString(obj);
> +	 return ToWebCoreString(obj);
> +    }
> +
> +    // FIXME: Remove once migration is complete.
> +    inline String toWebCoreString(v8::Handle<v8::String> obj)
> +    {
> +	 return ToWebCoreString(obj);
>      }

Did you mean to put this file into this change? It's just reformatting to
2-space indent, which ain't good for WebKit anyway.

Otherwise, looks good.