[webkit-reviews] review denied: [Bug 25191] HTMLSelectElement doesn't return named options : [Attachment 29480] testcases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 21 08:43:21 PDT 2009

Eric Seidel <eric at webkit.org> has denied Dave Moore <davemoore at google.com>'s
request for review:
Bug 25191: HTMLSelectElement doesn't return named options

Attachment 29480: testcases

------- Additional Comments from Eric Seidel <eric at webkit.org>
No need to ask just a single person to review this.  WebKit generally just
marks thigns r=?.  then all reviewers see it, and qualified ones hopefully will
review it for you.

This test should be a JS style test.  see examples in fast/js/

or make-test-wrappers.

Any resources directory with a TEMPLATE.html in it, can serve as an example for
a js style test (or ojan/dimitri or I can give you more infos in person).

I thought that this test was supposed to fail, no?  You're adding passing
results.  Do we not have a bug?

r- for more info needed (since I thought this test was supposed to fail for

More information about the webkit-reviews mailing list