[webkit-reviews] review requested: [Bug 25290] REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document : [Attachment 29624] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 14:05:21 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 25290: REGRESSION(r41732): Crash when constructing XMLHttpRequest in a
detached document
https://bugs.webkit.org/show_bug.cgi?id=25290

Attachment 29624: proposed patch
https://bugs.webkit.org/attachment.cgi?id=29624&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I suggest making the new nsURL variable a RetainPtr<NSURL*>, and therefore
> avoiding autorelease.

Oops! Sorry, this code is completely unrelated, and certainly not ready for
review. Submitting a hopefully clean patch...


More information about the webkit-reviews mailing list