[webkit-reviews] review granted: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 29500] atkcomponentifacev2.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 21546: [GTK] ATK accessibility enhancements
https://bugs.webkit.org/show_bug.cgi?id=21546

Attachment 29500: atkcomponentifacev2.patch
https://bugs.webkit.org/attachment.cgi?id=29500&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>	  * page/gtk/AccessibilityObjectWrapperAtk.cpp:
>	  (core):
> 
[...]
> 
>	  * WebCoreSupport/ChromeClientGtk.cpp:
>	  (WebKit::widgetScreenPosition):
>	  (WebKit::ChromeClient::windowToScreen):
>	  (WebKit::ChromeClient::screenToWindow):

This looks good to me, too. I would split these two parts, though. I understand
the WebKit/gtk changes are more general, and the code is used, for instance, in
scroll view, so I'd prefer if you make two commits here.