[webkit-reviews] review granted: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 29500] atkcomponentifacev2.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 11:58:12 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 21546: [GTK] ATK accessibility enhancements

Attachment 29500: atkcomponentifacev2.patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>	  * page/gtk/AccessibilityObjectWrapperAtk.cpp:
>	  (core):
>	  * WebCoreSupport/ChromeClientGtk.cpp:
>	  (WebKit::widgetScreenPosition):
>	  (WebKit::ChromeClient::windowToScreen):
>	  (WebKit::ChromeClient::screenToWindow):

This looks good to me, too. I would split these two parts, though. I understand
the WebKit/gtk changes are more general, and the code is used, for instance, in
scroll view, so I'd prefer if you make two commits here.

More information about the webkit-reviews mailing list