[webkit-reviews] review granted: [Bug 25271] Fix the build with disabled DOM storage : [Attachment 29589] Fix disabled database support build as well

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 18 22:23:24 PDT 2009


Sam Weinig <sam at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 25271: Fix the build with disabled DOM storage
https://bugs.webkit.org/show_bug.cgi?id=25271

Attachment 29589: Fix disabled database support build as well
https://bugs.webkit.org/attachment.cgi?id=29589&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: WebCore/bindings/js/ScriptObjectQuarantine.cpp
> ===================================================================
> --- WebCore/bindings/js/ScriptObjectQuarantine.cpp	(revision 42609)
> +++ WebCore/bindings/js/ScriptObjectQuarantine.cpp	(working copy)
> @@ -34,8 +34,12 @@
>  #include "Database.h"
>  #include "Document.h"
>  #include "Frame.h"
> +#if ENABLE(DATABASE)
>  #include "JSDatabase.h"
> +#endif
> +#if ENABLE(DOM_STORAGE)
>  #include "JSStorage.h"
> +#endif

These #if'd #includes should be moved to the bottom of the #include list
(paragraphed separately)

Otherwise, r=me.


More information about the webkit-reviews mailing list