[webkit-reviews] review granted: [Bug 25277] If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box : [Attachment 29597] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 17 18:31:14 PDT 2009


mitz at webkit.org has granted Justin Garcia <justin.garcia at apple.com>'s request
for review:
Bug 25277: If there is no line wrapping, a caret can leave its containing block
but it shouldn't leave its root line box
https://bugs.webkit.org/show_bug.cgi?id=25277

Attachment 29597: patch
https://bugs.webkit.org/attachment.cgi?id=29597&action=review

------- Additional Comments from mitz at webkit.org
r=me
There's a problem with this and earlier caret painting patches in that the
difference between correct and incorrect behavior in the pixel test is below
our detection threshold. I am not sure what to do about it (maybe use the Mac
SPI that's exposed via DRT for getting caret rects?), but addressing that is
not part of this bug.


More information about the webkit-reviews mailing list