[webkit-reviews] review granted: [Bug 25257] event handlers are undefined in v8 binding of XMLHttpRequest. : [Attachment 29570] use null for default event handlers in XMLHttpRequest and XMLHttpRequestUpload of v8 binding

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Tony Chang
(Google) <tony at chromium.org>'s request for review:
Bug 25257: event handlers are undefined in v8 binding of XMLHttpRequest.
https://bugs.webkit.org/show_bug.cgi?id=25257

Attachment 29570: use null for default event handlers in XMLHttpRequest and
XMLHttpRequestUpload of v8 binding
https://bugs.webkit.org/attachment.cgi?id=29570&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Great! Just two nits:

> +2009-04-16  Fumitoshi Ukai  <ukai at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	Use null for unspecified event listener attributes of XMLHttpRequest
and XMLHttpRequestUpload in v8 binding.
> +	https://bugs.webkit.org/show_bug.cgi?id=25257
> +    
cf.http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
> +	 An event handler attribute, unless otherwise specified, can either
have the value null or be set to a Function object.
> +	 Initially, an event handler attribute must be set to null.

Indentation is off here as well as a line break missing?

> +2009-04-16  Fumitoshi Ukai  <ukai at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	Verify XMLHttpRequest has correct attribute value by default.
> +	https://bugs.webkit.org/show_bug.cgi?id=25257
> +

Ditto.