[webkit-reviews] review requested: [Bug 25268] Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject : [Attachment 29579] Reviewed by Simon Fraser.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 17 09:56:00 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25268: Move RenderPath and RenderSVGContainer onto a unified
clippedOverflowRectForRepaint on RenderSVGModelObject
https://bugs.webkit.org/show_bug.cgi?id=25268

Attachment 29579:	  Reviewed by Simon Fraser.
https://bugs.webkit.org/attachment.cgi?id=29579&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

	Remove more dead code from RenderSVGHiddenContainer.

	lineHeight and baselinePosition used to be on RenderSVGContainer
	(of which this is a subclass) because RenderSVGContainer used
	to be a RenderBox and always the renderer for <svg>
	Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
	and RenderSVGViewportContainer (when inside SVG content)
	so there is no need for RenderSVGHiddenContainer to have these
HTML-specific methods.

	* rendering/RenderSVGHiddenContainer.cpp:
	* rendering/RenderSVGHiddenContainer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42555
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 1 files changed, 16 insertions(+), 0 deletions(-)


More information about the webkit-reviews mailing list