[webkit-reviews] review granted: [Bug 25260] Finish V8 custom bindings for InspectorController : [Attachment 29571] Finish V8 custom bindings for InspectorController.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 25260: Finish V8 custom bindings for InspectorController
https://bugs.webkit.org/show_bug.cgi?id=25260

Attachment 29571: Finish V8 custom bindings for InspectorController.
https://bugs.webkit.org/attachment.cgi?id=29571&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebCore/bindings/v8/custom/V8InspectorControllerCustom.cpp

> +    Node* node = V8Proxy::DOMWrapperToNode<Node>(args[0]);
> +    if (!node)
> +	   return v8::Undefined();
> +
> +   InspectorController* inspectorController =
V8Proxy::ToNativeObject<InspectorController>(V8ClassIndex::INSPECTORCONTROLLER,
args.Holder());
> +   inspectorController->highlight(node);
> +
> +    return v8::Undefined();
> +}

^^^ indentation is off by one there.

otherwise, LGTM