[webkit-reviews] review denied: [Bug 25244] <option> elements inside an <optgroup> are bold on Chromium : [Attachment 29550] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 16 15:01:54 PDT 2009

Adele Peterson <adele at apple.com> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 25244: <option> elements inside an <optgroup> are bold on Chromium

Attachment 29550: patch

------- Additional Comments from Adele Peterson <adele at apple.com>
The code change is fine.

I don't think those comments belong in html4.css though.  If anything, we need
a comment in themeWin.css about why we're forcing the font to be inherited. 
Something like "Option font must be inherited because we depend on computing
the size of the <select> based on the size of the options, and they must use
the same font for that computation to be correct".

I hesitate to say anything about the Changelog, because I think we all usually
say too little in the logs, but I think you can probably have a more concise
explanation here.

This is really an r+, but I'd like you to edit the comments & ChangeLog before
you checkin.  If you do that, pretty much anyone can give you the final r+.

Nice work!

More information about the webkit-reviews mailing list