[webkit-reviews] review granted: [Bug 24527] caret does not paint the first time you focus on a 0px right padding RTL div : [Attachment 29341] patch w/ Layout test (version 3)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Xiaomei Ji
<xji at chromium.org>'s request for review:
Bug 24527: caret does not paint the first time you focus on a 0px right padding
RTL div
https://bugs.webkit.org/show_bug.cgi?id=24527

Attachment 29341: patch w/ Layout test (version 3)
https://bugs.webkit.org/attachment.cgi?id=29341&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
r=me, but the test could be improved:
* it's not really about editing, so it should live in fast/forms?
* the mouseDown()/mouseUp() could just use focus(), which works outside of DRT
* increasing the contrast by removing the red border should make the pixel test
more sensitive
* the test would be even better using outline (so there's no focus ring), and
setting overflow: so that in the failing case the caret does not draw at all.