[webkit-reviews] review requested: [Bug 25221] SVG renderers should share a base class, like how CSS Box model renderers do : [Attachment 29518] Add minimal RenderSVGModelObject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 15:14:29 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25221: SVG renderers should share a base class, like how CSS Box model
renderers do
https://bugs.webkit.org/show_bug.cgi?id=25221

Attachment 29518: Add minimal RenderSVGModelObject
https://bugs.webkit.org/attachment.cgi?id=29518&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			    |	30 ++++++++++++++
 WebCore/WebCore.pro			    |	 1 +
 WebCore/WebCore.scons			    |	 1 +
 WebCore/WebCore.vcproj/WebCore.vcproj	    |	 8 ++++
 WebCore/WebCore.xcodeproj/project.pbxproj  |	 8 ++++
 WebCore/rendering/RenderPath.cpp	    |	 3 +-
 WebCore/rendering/RenderPath.h 	    |	 9 ++--
 WebCore/rendering/RenderSVGContainer.cpp   |	 2 +-
 WebCore/rendering/RenderSVGContainer.h     |	 6 +--
 WebCore/rendering/RenderSVGModelObject.cpp |	46 ++++++++++++++++++++++
 WebCore/rendering/RenderSVGModelObject.h   |	57 ++++++++++++++++++++++++++++
 WebCore/rendering/RenderTreeAsText.cpp     |	 1 +
 WebCore/rendering/SVGRenderTreeAsText.cpp  |	 1 +
 13 files changed, 161 insertions(+), 12 deletions(-)


More information about the webkit-reviews mailing list