[webkit-reviews] review denied: [Bug 21794] Middle-click panning should be springloaded while dragging : [Attachment 29506] Updated version of previous patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Itai
<idanan at chromium.org>'s request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 29506: Updated version of previous patch
https://bugs.webkit.org/attachment.cgi?id=29506&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-04-15  Itai Danan  <set EMAIL_ADDRESS environment variable>
> +	   As per Bug 21794 (https://bugs.webkit.org/show_bug.cgi?id=21794),
> +	added an option for springloaded panscroll instead of sticky
> +	scroll. To understand why this is required see the discussion in
> +	issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).	

^^^ please replace tab characters with spaces.


> Index: WebCore/page/EventHandler.cpp
...
>      m_currentMousePosition = mouseEvent.pos();
>  
> +    if (!m_frame->settings()->stickyPanScroll())
> +	 if (m_frame->page() &&
m_frame->page()->mainFrame()->eventHandler()->panScrollInProgress() ||
m_autoscrollInProgress) {
> +	   stopAutoscrollTimer();
> +	   invalidateClick();
> +	   return true;
> +	 }
> +

^^^ please change to use 4 space indentation