[webkit-reviews] review granted: [Bug 25201] Add ScriptFunctionCall/ScriptObject for V8 : [Attachment 29488] Add ScriptFunctionCall/ScriptObject for V8, v1.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 25201: Add ScriptFunctionCall/ScriptObject for V8
https://bugs.webkit.org/show_bug.cgi?id=25201

Attachment 29488: Add ScriptFunctionCall/ScriptObject for V8, v1.
https://bugs.webkit.org/attachment.cgi?id=29488&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebCore/bindings/v8/ScriptObject.cpp
...
> +#include "config.h"
> +#include "ScriptObject.h"
> +#include "ScriptScope.h"
> +#include "ScriptState.h"

nit: insert newline after ScriptObject.h


> +++ b/WebCore/bindings/v8/ScriptObject.h
...
> +    class ScriptObject : public ScriptValue {
...
> +	   static ScriptObject createNew(ScriptState*);

nit: isn't it more common to just call a function like this "create" instead?


> +++ b/WebCore/bindings/v8/ScriptObjectQuarantine.cpp
...
> +bool getQuarantinedScriptObject(Database* database, ScriptObject&
quarantinedObject)
> +{
> +    ASSERT(database);
> +
> +    // FIXME: Implement when Database V8 bindings are enabled

nit: maybe add an ASSERT_NOT_REACHED?


> +    // FIXME: Implement when DOM Storage V8 bindings are enabled

ditto


LGTM