[webkit-reviews] review granted: [Bug 25172] Extra partial layout during the first keypress in an empty block : [Attachment 29477] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 25172: Extra partial layout during the first keypress in an empty block
https://bugs.webkit.org/show_bug.cgi?id=25172

Attachment 29477: patch
https://bugs.webkit.org/attachment.cgi?id=29477&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  Please add a comment to the ChangeLog about why there is no test.
:)

I can see why you said that you thought offsetInContainerNode() should be
renamed offsetInAnchorNode().  Now that containerNode() got renamed
computeContainerNode() you end up using anchorNode() instead.  Maybe we want a
containerNode() accessor which ASSERTS like offsetInContainerNode() does.

Anyway, that's a discussion for another bug (or email thread).

r+