[webkit-reviews] review denied: [Bug 25175] It is possible for unique anonymous functions to hash to the same value, thus showing up as one function in the profiler : [Attachment 29461] Added reference to actual function to tell them apart.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 14 02:45:43 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Francisco Tolmasky
<tolmasky at gmail.com>'s request for review:
Bug 25175: It is possible for unique anonymous functions to hash to the same
value, thus showing up as one function in the profiler
https://bugs.webkit.org/show_bug.cgi?id=25175

Attachment 29461: Added reference to actual function to tell them apart.
https://bugs.webkit.org/attachment.cgi?id=29461&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The CallIdentifier should just take a JSObject* rather than the jsvalueptr


More information about the webkit-reviews mailing list