[webkit-reviews] review denied: [Bug 25171] It should be possible to manually set the name of an anonymous function : [Attachment 29454] Moved new code out of name and into calculatedDisplayName

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 20:26:52 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Francisco Tolmasky
<tolmasky at gmail.com>'s request for review:
Bug 25171: It should be possible to manually set the name of an anonymous
function
https://bugs.webkit.org/show_bug.cgi?id=25171

Attachment 29454: Moved new code out of name and into calculatedDisplayName
https://bugs.webkit.org/attachment.cgi?id=29454&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
static const UString * AnonymousFunction = new UString("(anonymous function)");


This shouldn't be heap allocated otherwise it will cause leak warnings, it's
also potentially not threadsafe -- I recommend putting an additional string
constant on GlobalData to contain "(anonymous function)"


More information about the webkit-reviews mailing list